Simplify configuration#8
Closed
LordGaav wants to merge 2 commits into
Closed
Conversation
added 2 commits
May 2, 2023 17:00
djfarrelly
added a commit
that referenced
this pull request
Jul 6, 2026
Adopt the flexibility idea from #8 (thanks @LordGaav) without giving up the structured, documented values. extraArgs are appended after the chart-generated flags and extraEnv is passed through verbatim, so users can set any maildev option the chart does not model — including env from Secrets via valueFrom, which a plain env map cannot express. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Thanks @LordGaav — the escape-hatch idea here is the right instinct. We're consolidating the maildev 2.x fix into #9, which keeps structured/documented values for the common options (and can wire up the auto-relay ConfigMap + volume, which a raw env map can't) while adding |
djfarrelly
added a commit
that referenced
this pull request
Jul 7, 2026
Adopt the flexibility idea from #8 (thanks @LordGaav) without giving up the structured, documented values. extraArgs are appended after the chart-generated flags and extraEnv is passed through verbatim, so users can set any maildev option the chart does not model — including env from Secrets via valueFrom, which a plain env map cannot express. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've opted to simplify the configuration of this Chart by directly exposing the command, arguments and environment variables. Specifically allowing configuration of the arguments allows the user to work around the env var issue. This change also makes the Chart compatible the latest MailDev 2.x version.
This change breaks backwards compatibility, so I've also bumped the Chart version.